Back to PR #22064

Pull Requests

Ensure that `valueOf()` (which may throw) is not called when rendering objects

[Flight] Enable Binary and ReadableStreams in Stable

Track Stack of JSX Calls

ADD A CODE COMMENT

Use `FormData` `submitter` parameter

Remove 2 no longer existing files from inlinedHostConfig

Upgrade jest and jsdom

Facebook: merge react index.classic.fb and index.modern.fb

fix[react-devtools/InspectedElementView.css]: dont draw bottom border for empty badge list

React DevTools 5.1.0 -> 5.2.0

Support useFormStatus in progressively-enhanced forms

fix[react-devtools/ci]: fix configurations for e2e testing

Clean up fastAddProperties and make it more correct

feat[react-devtools]: display forget badge for components in profiling session

[Flight Reply] Encode Objects Returned to the Client by Reference

Check if we ever test without consoleManagedByDevToolsDuringStrictMode

Stop using Scheduler.log to test double invocations

Dim `console` calls on additional Effect invocations due to `StrictMode`

Allow specifying timeout in tests via third argument

"TypeError: Cannot read property 'setState' of null" when using React.lazy

Add FB build for ReactReconcilerConstants

Update getComments.js

[Flight] Test deduplication with streaming server components

[Flight Reply] Dedupe Objects and Support Cyclic References

[Flight] Encode references to existing objects by property path

refactored shebangs

Setup Wave 2 of Feature Flags for React Native

Update `compiled-rn` destination paths to `vendor/react`

[Flight Reply] Resolve outlined models async in Reply just like in Flight Client

[Fizz] Fallback to client replaying actions if we're trying to serialize a Blob

[Flight Reply] Encode binary streams as a single collapsed Blob

fix[react-devtools]: add backwards compat with legacy element type symbol

Repro for string ref + enableRefAsProp unstable props

Bundle config: Rename `global` to `hasteFileName` in bundle config

Bundle config: inline internal hook wrapper

Enable Wave 1 of Feature Flags for React Native

Devtools: Fix build-for-devtools

Devtools: Streamline getting extension from branch

DevTools: Fix inspecting components with multiple reads of the same Context in React 17

[DevTools] Expose "view source" options to Fusebox integration

[DevTools] Enable inspected element context menu in Fusebox

[DevTools] Check in `frontend.d.ts` for react-devtools-fusebox, include in build output

Introduce a faster version of the addProperties function

[Tooling] Update critical artifact list

[Fiber] render boundary in fallback if it contains a new stylesheet during sync update

Set enableUseMemoCacheHook to true everywhere

Stop committing resources to an external repo

Add `bun` to `react-dom`'s `package.json`.

typo: fix typos in codes.json

Build Activity

Add DEV-only string coercion checks to prod files This commit adds DEV-only function calls to to check if string coercion using `'' + value` will throw, which it will if the value is a Temporal object or a symbol because those types can't be added wit...

Improve debugging DX when string coercions fail If a coercion throws, the check function will now throw after it calls console.error(). It's the same exception that will be thrown after the check function returns, but by throwing it inside of the chec...

Change DEV checks from throwing to console.error This commit revises behavior of DEV string-coercion check functions to use console.error instead of throwing a TypeError. There will still be an exception thrown but it will be the being-coerced value t...

Don't report lint error if coercion is safe This commit extends the safe-string-coercion internal ESLint rule to auto-detect code where coercion can't fail or is correctly preceded by a DEV check. In those cases, the rule now won't report. Changes: *...

Don't report lint error if coercion is safe This commit extends the safe-string-coercion internal ESLint rule to auto-detect code where coercion can't fail or is correctly preceded by a DEV check. In those cases, the rule now won't report. Changes: *...

Add disallowStringConstructor option to lint rule This commit adds a new option to the react-internal/safe-string-coercion lint rule that controls whether `String(value)` should be disallowed. ESLint is now configured set up to disallow `String(value...

Test for different error messages in DEV vs PROD Tests will now check for a different error message in Prod, which aligns with actual prod behavior where the error will be thrown by the Temporal or Symbol object, not by React

Revise ESLint rules for string coercion To make string-coercion safer and to improve user-facing error messages, This commit makes the following changes to coercion-related internal ESLint rules: * Adds a new rule for the `'' + value` and `value + ''`...

Change `''.concat(value)` to `String(value)` `''.concat(value)` violates current Flow definitons that require args to concat to be strings only, even though the MDN docs and ES spec allow args to be any type. See https://github.com/facebook/flow/issue...

Replace `'' + obj` pattern with `''.concat(obj)` Using the `+` operator to concatenate strings and objects is problematic because `+` calls `valueOf` on the object. `valueOf` will throw for some types of objects. See #20594 for details. This commit g...

Replace `'' + obj` pattern with `''.concat(obj)` Using the `+` operator to concatenate strings and objects is problematic because `+` calls `valueOf` which will throw for some types. See #20594 for details. This commit globally replaces `'' + obj` wi...

Don't call valueOf during string concatenation The new Temporal (https://github.com/tc39/proposal-temporal) date/time API (currently stage 3) will throw when calling `valueOf` on instances of most Temporal types. This behavior breaks react-dom's ren...

Convert to string before concatenation The new Temporal (https://github.com/tc39/proposal-temporal) date/time API (currently stage 3) will throw when calling `valueOf` on instances of most Temporal types. This behavior breaks react-dom's rendering o...

Merge branch 'facebook:main' into patch-2

Convert to string before concatenation The new [Temporal](https://github.com/tc39/proposal-temporal) date/time API (currently stage 3) will throw when calling `valueOf` on instances of most Temporal types. This behavior breaks react-dom's rendering...

facebook/react #159941

Started 3 years ago • duration: 03:14
justingrant opened pull request #22064 to main

Loading Sandboxes...

Loading Packages...

Loading Install Instructions...

Finished!

Loading...