Remove PassiveStatic optimization Passive flags are a new concept that is tricky to get right. We've already found two bugs related to PassiveStatic. Let's remove this optimization for now, and add it back once the main part of the effects refactor la...

Remove PassiveStatic optimization Passive flags are a new concept that is tricky to get right. We've already found two bugs related to PassiveStatic. Let's remove this optimization for now, and add it back once the main part of the effects refactor la...

Convert passive mount phase to tree traversal

Remove PassiveStatic optimization Passive flags are a new concept that is tricky to get right. We've already found two bugs related to PassiveStatic. Let's remove this optimization for now, and add it back once the main part of the effects refactor la...

Convert passive mount phase to tree traversal

Remove PassiveStatic optimization Passive flags are a new concept that is tricky to get right. We've already found two bugs related to PassiveStatic. Let's remove this optimization for now, and add it back once the main part of the effects refactor la...

Don't clear static flags in resetWorkInProgress Fixes the regression test added in #20433

Convert passive unmount phase to tree traversal

Defer more field detachments to passive phase This allows us to use those fields during passive unmount traversal.

Convert passive mount phase to tree traversal

Add PassiveStatic to trees with passive effects Indicates that a tree needs passive clean-up on deletion.

Don't clear other flags when adding Deletion Same as #20398 but for Deletions. There's no new regression test, but in the effects refactor, existing tests will fail without this.

Add back disableSchedulerTimeoutInWorkLoop flag (#20482) * Add back enableSchedulerTimeoutInWorkLoop flag * Nvm, keep it as disableSchedulerTimeoutInWorkLoop

Revert to last successful www sync

Remove PassiveStatic optimization Passive flags are a new concept that is tricky to get right. We've already found two bugs related to PassiveStatic. Let's remove this optimization for now, and add it back once the main part of the effects refactor la...

Don't clear static flags in resetWorkInProgress Fixes the regression test added in #20433

Convert passive unmount phase to tree traversal

Defer more field detachments to passive phase This allows us to use those fields during passive unmount traversal.

Don't clear static flags in resetWorkInProgress Fixes the regression test added in #20433

Convert passive mount phase to tree traversal

Add PassiveStatic to trees with passive effects Indicates that a tree needs passive clean-up on deletion.

Don't clear other flags when adding Deletion Same as #20398 but for Deletions. There's no new regression test, but in the effects refactor, existing tests will fail without this.

Add back disableSchedulerTimeoutInWorkLoop flag (#20482) * Add back enableSchedulerTimeoutInWorkLoop flag * Nvm, keep it as disableSchedulerTimeoutInWorkLoop

Revert to last successful www sync

Convert passive mount phase to tree traversal

Consolidate passive callback logic Not super interesting. I put this in its own commit so that the previous one is more focused.

Remove PassiveStatic optimization Passive flags are a new concept that is tricky to get right. We've already found two bugs related to PassiveStatic. Let's remove this optimization for now, and add it back once the main part of the effects refactor la...

Remove PassiveStatic optimization Passive flags are a new concept that is tricky to get right. We've already found two bugs related to PassiveStatic. Let's remove this optimization for now, and add it back once the main part of the effects refactor la...

Remove PassiveStatic optimization Passive flags are a new concept that is tricky to get right. We've already found two bugs related to PassiveStatic. Let's remove this optimization for now, and add it back once the main part of the effects refactor la...

Remove PassiveStatic optimization Passive flags are a new concept that is tricky to get right. We've already found two bugs related to PassiveStatic. Let's remove this optimization for now, and add it back once the main part of the effects refactor la...

Consolidate passive callback logic Not super interesting. I put this in its own commit so that the previous one is more focused.

Remove PassiveStatic optimization Passive flags are a new concept that is tricky to get right. We've already found two bugs related to PassiveStatic. Let's remove this optimization for now, and add it back once the main part of the effects refactor la...

Consolidate passive callback logic Not super interesting. I put this in its own commit so that the previous one is more focused.

Convert passive unmount phase to tree traversal

Consolidate passive callback logic Not super interesting. I put this in its own commit so that the previous one is more focused.

Convert passive unmount phase to tree traversal

Defer more field detachments to passive phase This allows us to use those fields during passive unmount traversal.

Convert passive mount phase to tree traversal

Consolidate passive callback logic Not super interesting. I put this in its own commit so that the previous one is more focused.

Move onPostCommit to actual passive phase Original PR: #19862

Remove passive logic from layout phase Original PR: #19809

Convert passive unmount phase to tree traversal

Convert passive mount phase to tree traversal

Add PassiveStatic to trees with passive effects Indicates that a tree needs passive clean-up on deletion.

Don't clear other flags when adding Deletion Same as #20398 but for Deletions. There's no new regression test, but in the effects refactor, existing tests will fail without this.

Consolidate passive callback logic Not super interesting. I put this in its own commit so that the previous one is more focused.

Move onPostCommit to actual passive phase Original PR: #19862

Remove passive logic from layout phase Original PR: #19809

Convert passive unmount phase to tree traversal

Defer more field detachments to passive phase This allows us to use those fields during passive unmount traversal.

Convert passive mount phase to tree traversal

Add PassiveStatic to trees with passive effects Indicates that a tree needs passive clean-up on deletion.

Double Invoke Effects in __DEV__ (in old reconciler fork) (#20415) We originally added a new DEV behavior of double-invoking effects during mount to our new reconciler fork in PRs #19523 and #19935 and later refined it to only affect modern roots in P...

Consolidate passive callback logic Not super interesting. I put this in its own commit so that the previous one is more focused.

Move onPostCommit to actual passive phase Original PR: #19862

Remove passive logic from layout phase Original PR: #19809

Convert passive unmount phase to tree traversal

Defer more field detachments to passive phase This allows us to use those fields during passive unmount traversal.

Convert passive mount phase to tree traversal

Add PassiveStatic to trees with passive effects Indicates that a tree needs passive clean-up on deletion.

Don't clear other flags when adding Deletion Same as #20398 but for Deletions. There's no new regression test, but in the effects refactor, existing tests will fail without this.

Move onPostCommit to actual passive phase Original PR: #19862

Remove passive logic from layout phase Original PR: #19809

Convert passive unmount phase to tree traversal

Convert passive unmount phase to tree traversal

Convert passive unmount phase to tree traversal

Defer more field detachments to passive phase This allows us to use those fields during passive unmount traversal.

Convert passive mount phase to tree traversal

Add PassiveStatic to trees with passive effects Indicates that a tree needs passive clean-up on deletion.

Don't clear other flags when adding Deletion Same as #20398 but for Deletions. There's no new regression test, but in the effects refactor, existing tests will fail without this.

Clear `deletions` in `detachFiber` This was added in a later step of the refactor but since `deletions` array already landed, clearing it should, too. I think it's unlikely that this causes GC problems but worth adding anyway.

Consolidate passive callback logic Not super interesting. I put this in its own commit so that the previous one is more focused.

Move onPostCommit to actual passive phase Original PR: #19862

Remove passive logic from layout phase Original PR: #19809

Convert passive unmount phase to tree traversal

Convert passive mount phase to tree traversal

Add PassiveStatic to trees with passive effects Indicates that a tree needs passive clean-up on deletion.

Don't clear other flags when adding Deletion Same as #20398 but for Deletions. There's no new regression test, but in the effects refactor, existing tests will fail without this.

Consolidate passive callback logic Not super interesting. I put this in its own commit so that the previous one is more focused.

Consolidate passive callback logic Not super interesting. I put this in its own commit so that the previous one is more focused.

Track subtreeFlags et al with bubbleProperties Original PR: #19836

Remove `catch` from Scheduler build (#20396) Makes debugging errors harder. In this case, we can use `finally` instead.

Consolidate passive callback logic Not super interesting. I put this in its own commit so that the previous one is more focused.

Move onPostCommit to actual passive phase Original PR: #19862

Remove passive logic from layout phase Original PR: #19809

Migrate passive phase to depth first traversal Because the passive phase happens after paint, I expect it's least likely to cause a performance regression. In terms of implementation complexity, however, it's probably the riskiest. Ideally, for this ...

Track subtreeFlags et al with bubbleProperties Original PR: #19836

Track deletions using an array on the parent Adds back the `deletions` array and uses it in the commit phase. We use a trick where the first time we hit a deletion effect, we commit all the deletion effects that belong to that parent. This is an incr...

Consolidate passive callback logic Not super interesting. I put this in its own commit so that the previous one is more focused.

Move onPostCommit to actual passive phase Original PR: #19862

Move onPostCommit to actual passive phase Original PR: #19862

Move onPostCommit to actual passive phase Original PR: #19862

Move onPostCommit to actual passive phase Original PR: #19862

Move onPostCommit to actual passive phase Original PR: #19862

Consolidate passive callback logic Not super interesting. I put this in its own commit so that the previous one is more focused.

Move onPostCommit to actual passive phase Original PR: #19862

Remove passive logic from layout phase Original PR: #19809

Migrate passive phase to depth first traversal Because the passive phase happens after paint, I expect it's least likely to cause a performance regression. In terms of implementation complexity, however, it's probably the riskiest. Ideally, for this ...

Track subtreeFlags et al with bubbleProperties Original PR: #19836

Track deletions using an array on the parent Adds back the `deletions` array and uses it in the commit phase. We use a trick where the first time we hit a deletion effect, we commit all the deletion effects that belong to that parent. This is an incr...

Consolidate passive callback logic Not super interesting. I put this in its own commit so that the previous one is more focused.

Consolidate passive callback logic Not super interesting. I put this in its own commit so that the previous one is more focused.

Move onPostCommit to actual passive phase Original PR: #19862

Move onPostCommit to actual passive phase Original PR: #19862

Move onPostCommit to actual passive phase Original PR: #19862

Remove passive logic from layout phase Original PR: #19809

Migrate passive phase to depth first traversal Because the passive phase happens after paint, I expect it's least likely to cause a performance regression. In terms of implementation complexity, however, it's probably the riskiest. Ideally, for this ...

Migrate passive phase to depth first traversal Because the passive phase happens after paint, I expect it's least likely to cause a performance regression. In terms of implementation complexity, however, it's probably the riskiest. Ideally, for this ...

Undo previous steps This undoes the previous steps in the refactor. The next step will restore the fork to the final endpoint that includes all the changes. The reason for this intermediate commit is so that I can make incremental changes to the earl...

Migrate passive phase to depth first traversal Because the passive phase happens after paint, I expect it's least likely to cause a performance regression. In terms of implementation complexity, however, it's probably the riskiest. Ideally, for this ...

Track subtreeFlags et al with bubbleProperties Original PR: #19836

Track deletions using an array on the parent Adds back the `deletions` array and uses it in the commit phase. We use a trick where the first time we hit a deletion effect, we commit all the deletion effects that belong to that parent. This is an incr...

Remaining effects refactor changes This includes all the remaining changes in the effects refactor. It started as a revert of eb2758.

Track subtreeFlags et al with bubbleProperties Original PR: #19836

Remaining effects refactor changes This includes all the remaining changes in the effects refactor. It started as a revert of eb2758.

Track subtreeFlags et al with bubbleProperties Original PR: #19836

Track deletions using an array on the parent Adds back the `deletions` array and uses it in the commit phase. We use a trick where the first time we hit a deletion effect, we commit all the deletion effects that belong to that parent. This is an incr...

Remaining effects refactor changes This includes all the remaining changes in the effects refactor. It started as a revert of eb2758.

Warn if commit phase error thrown in detached tree Until `skipUnmountedBoundaries` lands again, I need some way to detect when errors are thrown inside a deleted tree. So I've added a warning to `captureCommitPhaseError` that fires when we reach the r...

Undo previous steps This undoes the previous steps in the refactor. The next step will restore the fork to the final endpoint that includes all the changes. The reason for this intermediate commit is so that I can make incremental changes to the earl...

Track deletions using an array on the parent Adds back the `deletions` array and uses it in the commit phase. We use a trick where the first time we hit a deletion effect, we commit all the deletion effects that belong to that parent. This is an incr...

Add Node ESM Loader and Register Entrypoints (#20274) * Add Node ESM loader build This adds a loader build as a first-class export. This will grow in complexity so it deserves its own module. * Add Node CommonJS regiter build This adds a bui...

Remaining effects refactor changes This includes all the remaining changes in the effects refactor. It started as a revert of eb2758.

Undo previous steps This undoes the previous steps in the refactor. The next step will restore the fork to the final endpoint that includes all the changes. The reason for this intermediate commit is so that I can make incremental changes to the earl...

Track deletions using an array on the parent Adds back the `deletions` array and uses it in the commit phase. We use a trick where the first time we hit a deletion effect, we commit all the deletion effects that belong to that parent. This is an incr...

Remaining effects refactor changes This includes all the remaining changes in the effects refactor. It started as a revert of eb2758.

Undo previous steps This undoes the previous steps in the refactor. The next step will restore the fork to the final endpoint that includes all the changes. The reason for this intermediate commit is so that I can make incremental changes to the earl...

Remaining effects refactor changes This includes all the remaining changes in the effects refactor. It started as a revert of eb2758.

Undo previous steps This undoes the previous steps in the refactor. The next step will restore the fork to the final endpoint that includes all the changes. The reason for this intermediate commit is so that I can make incremental changes to the earl...

Undo previous steps This undoes the previous steps in the refactor. The next step will restore the fork to the final endpoint that includes all the changes. The reason for this intermediate commit is so that I can make incremental changes to the earl...

Revert "Reset new fork to old fork" This reverts commit eb2758b5344903abacc2e6d0d82c64bf0f5fa873. Something in the new fork is causing a topline metrics regression. We're not sure what it is, so we're going to split it into steps and bisect. As a fi...

Revert "Reset new fork to old fork" This reverts commit eb2758b5344903abacc2e6d0d82c64bf0f5fa873. Something in the new fork is causing a topline metrics regression. We're not sure what it is, so we're going to split it into steps and bisect. As a fi...

Revert "Reset new fork to old fork" This reverts commit eb2758b5344903abacc2e6d0d82c64bf0f5fa873. Something in the new fork is causing a topline metrics regression. We're not sure what it is, so we're going to split it into steps and bisect. As a fi...